Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous styles on documentElement are not restored #10

Open
pugbyte opened this issue Jan 2, 2019 · 0 comments
Open

Previous styles on documentElement are not restored #10

pugbyte opened this issue Jan 2, 2019 · 0 comments
Labels
bug help wanted

Comments

@pugbyte
Copy link

pugbyte commented Jan 2, 2019

I had a use case where the documentElement had inline styles on it, like so: <html style="padding: 0; margin: 0; overflow-x=hidden;">. I noticed that after toggling no-scroll to off, the overflow-x=hidden was being wiped out. After checking the code in no-scroll, I found that it's hard-coding the style attributes when off() is called. I think that no-scroll should be restoring whatever values were set before on() was called, instead of overwriting them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidtheclark @pugbyte