Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on error mechanism #203

Closed
pPrecel opened this issue Mar 16, 2024 · 2 comments
Closed

Retry on error mechanism #203

pPrecel opened this issue Mar 16, 2024 · 2 comments

Comments

@pPrecel
Copy link

pPrecel commented Mar 16, 2024

Description:

From time to time I got the error:

Error: Invalid login: 535 5.7.139 Authentication unsuccessful, the user credentials were incorrect.

It looks like something is not ok with creds passed to the action, but it's not. Re-running the failed workflow or this specific step is enough to send mail.

It would be really helpful if the send-mail action had a configurable retry mechanism to cover such cases when a step fails with such a dummy error
@dawidd6
Copy link
Owner

dawidd6 commented Mar 16, 2024

Is this PR something you would be happy with?
#197

If not, please submit another PR.

@pPrecel
Copy link
Author

pPrecel commented Mar 23, 2024

yes! thanks. I can't wait for the new release :)

@pPrecel pPrecel closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dawidd6 @pPrecel