Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #196 #197

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix for issue #196 #197

merged 1 commit into from
Feb 14, 2024

Conversation

kroese
Copy link
Contributor

@kroese kroese commented Feb 9, 2024

Fixes issue #196

@dawidd6
Copy link
Owner

dawidd6 commented Feb 14, 2024

Could you somehow simplify those changes? Maybe we can use some third-party npm package providing a functionality for retry-backoff mechanism?

@kroese
Copy link
Contributor Author

kroese commented Feb 14, 2024

I have almost zero experience with NodeJS / npm. I just wrote that code in the Github editor without any development enviroment.

Its just a simple loop, and already does something similar to retry-backoff by increasing the amount of minutes to wait each time the try fails. I tested it for several days, and the highest number of tries needed before Gmail accepted the message was 7 tries, so the limit of 10 seems a sane value.

If you want to do something more fancy, no problem. But for my usecase this loop already is a big improvement, because before the action failed multiple times per day (using the Google Workspaces smtp server) and now it always finishes succesfully.

@dawidd6 dawidd6 merged commit 2afa768 into dawidd6:master Feb 14, 2024
@dawidd6
Copy link
Owner

dawidd6 commented Feb 14, 2024

Alright, thanks.

@dawidd6 dawidd6 mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants