Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "replay" button #155

Closed
mike-thompson-day8 opened this issue Feb 16, 2018 · 2 comments
Closed

Add new "replay" button #155

mike-thompson-day8 opened this issue Feb 16, 2018 · 2 comments

Comments

@mike-thompson-day8
Copy link
Contributor

mike-thompson-day8 commented Feb 16, 2018

Add a new "replay" button which performs two steps:

  1. resets app-db to the value it had prior to the current event, and then, once all consequent computation is complete (subscriptions have run and views have updated - dominoes 4,5,6),
  2. re-dispatches the current event.

So it provides for an action replay of the "current event". The one to which the user has navigated.

Notes:

  • Any trace arising out of Step 1 is ignored (any change to app-db will trigger subscriptions and views)
  • All trace arising out of Step 2 forms a normal epoch which is appended to the end of the existing epoch list, AND the user is transported to view this new epoch. So they immediately see the results for this new epoch.
  • Button should be visible/available in all tabs.

Will be useful:

  1. in the Timings tab to see if the numbers are stable across multiple runs.
  2. whenever we hotload (via figwheel) a fixed/altered event handler, subscription handler or view, and we want to test if our change works. Figwheel+replayis lovely, simple debugging move.

image

Open Questions:

  1. should this button be visible if the user has "paused" collection of events? Probably not.
  2. should it be muted as depicted? Or strong blue?
This was referenced Feb 16, 2018
@mike-thompson-day8 mike-thompson-day8 changed the title Add new "rerun" button and Remove structure at top of app-db tab Add new "rerun" button Feb 17, 2018
@mike-thompson-day8 mike-thompson-day8 changed the title Add new "rerun" button Add new "replay" button Feb 17, 2018
@mike-thompson-day8
Copy link
Contributor Author

@Gregg8
Copy link
Contributor

Gregg8 commented Mar 26, 2018

Replay button UI added (and info button hooked up to Mike's document). Just needs connecting to the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants