Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace optimist #224

Closed
wzrdtales opened this issue Feb 13, 2015 · 6 comments · Fixed by #679
Closed

Replace optimist #224

wzrdtales opened this issue Feb 13, 2015 · 6 comments · Fixed by #679
Assignees
Milestone

Comments

@wzrdtales
Copy link
Member

wzrdtales commented Feb 13, 2015

Replace optimist with a better component. As it's no longer support by the developer and doesn't met the requirements anymore.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@wzrdtales wzrdtales self-assigned this Feb 13, 2015
@wzrdtales wzrdtales added this to the v0.10.0 milestone Feb 13, 2015
@wzrdtales wzrdtales modified the milestones: v0.11.0, v0.10.0 Mar 14, 2015
@wzrdtales
Copy link
Member Author

Was moved to v0.11.0, actually we leave it in place for v0.10.x as we're going to take a look at several solutions and make decision afterwards.

@listepo
Copy link

listepo commented May 7, 2015

@wzrdtales
Copy link
Member Author

wzrdtales commented Jul 15, 2016

When replacing optimist, also rework the way db-migrate initialize. Currently db-mgrate needs ~0.22s for pure init before anything gets printed to the console.

Just by moving the command line parser to be the first item after instance identification will enable us a initialization time of ~0.07s instead.

@wzrdtales
Copy link
Member Author

wzrdtales commented Jul 15, 2016

We had an increase from ~0.09s from version 0.9.x to 0.10.x, the reason for this is tunnel-ssh.

One level deeper it shows that actually ssh2 seems to be the slow one.

@wzrdtales
Copy link
Member Author

Opened item #387 to immediately fix the issue with tunnel-ssh.

@ebaynaud
Copy link

ebaynaud commented Mar 18, 2020

This becomes important because of a vulnerability found in the version of minimist that optimist depends on. (In addition, mkdirp should be upgraded as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants