Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'pass through' column info #34

Closed
brweber2 opened this issue Jul 30, 2012 · 3 comments
Closed

Add support for 'pass through' column info #34

brweber2 opened this issue Jul 30, 2012 · 3 comments

Comments

@brweber2
Copy link

This would enable db specific column info. For example, on a table create:

db.createTable( 'name', {
id: { type: 'uuid',
passthrough: true,
primaryKey: true
}
}

If an unrecognized type is found and passthrough is not explicitly set to true, you could throw an error. If passthrough is true, just write out the value to a string and try to execute the sql...

This would enable me to maintain my table info in a consistent, declarative manner instead of having to sometimes drop down to executing full blown native sql queries.

@kunklejr
Copy link
Contributor

kunklejr commented Aug 2, 2012

What do you think about the idea of simply passing an unknown data type through unchanged but logging a warning when doing so?

@brweber2
Copy link
Author

brweber2 commented Aug 3, 2012

I'm fine with that way too. I basically want a workaround for db specific DDL/DML.

I certainly don't like the verbose 'passThrough' key, but I was struggling to find an appropriate name, so maybe the warning is the way to go.

@kunklejr
Copy link
Contributor

kunklejr commented Aug 3, 2012

Unknown data types are simply passed through unchanged with an accompanying warning message. See commit 2936b44 for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants