Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on cert-manager #20

Open
bit-herder opened this issue Oct 23, 2023 · 2 comments
Open

dependency on cert-manager #20

bit-herder opened this issue Oct 23, 2023 · 2 comments

Comments

@bit-herder
Copy link

Hi I noticed when installing this on a cluster that there is an implicit dep on cert-manager. Maybe you guys should add that to the chart deps? Its pretty plain in the values file but its undocumented beyond that I think. Also, we have the webhook creation set to false but this logic is still being triggered and we cannot install without first installing cert-manager. Thats fine, but its good to know for dependencies.

@bit-herder
Copy link
Author

bit-herder commented Oct 23, 2023

I was able to find a way out of this personally but I think its still a dep.

I can disable the webhook and get a working install without cert-manger with:

  values:
    webhook:
      enabled: false
      certificate:
        create: false
        issuer: 
          create: false 

@allanger
Copy link
Member

allanger commented Jan 3, 2024

I haven't seen this issue, I guess.
Yes, it's a dependency, but helm dependencies is a bad way to define actual dependencies, because it's just something to be installed alongside the main chart.

I want to make the chart independent of cert-manager one day. So I'll reopen this issue.

@allanger allanger reopened this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants