Guava 12.0 & Junit 4.10 Updated #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced guava r 7 with 12 and junit 4.7 with 4.10
Test suites using annotations. Master runs all tests. Others run each test inside group. Master calls only the suites.
|
I merged the change, thank you very much. Check out Topic Branches in this readme for the branching thing. |
|
Thanks Daniel! You have been a lot of help. I'll try branching out the other potential changes this weekend. Jeremy -----Original Message----- I merged the change, thank you very much. Check out Topic Branches in this readme for the branching thing. Reply to this email directly or view it on GitHub: No virus found in this message. |
hazendaz
added a commit
that referenced
this pull request
Jul 12, 2020
…ito-core-3.4.0 Bump mockito-core from 3.3.3 to 3.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated Guava from r7 to 12 and changed the concurrent map implementation that has been deprecated to the new cache modules. I added some test suites. One to run all test suites and a test suite in each sub package. I updated junit to 4.10. No coding changes were required for junit changes. My test cases are using annotation. I updated the change log and added it at 1.5 snapshot. I noticed that version 1.4 doesn't quite have all the recent changes. I think it might be helpful for others if a 1.5 Snapshot is available for download so it matches the master.
I replaced the old jars with the new ones.
As for test cases, all passed except for the impersonate tests. I got a 5 back on 4 of those tests rather than 0. From what I could find on google, sounds like that is a security issue.
I still haven't quite figured out how to branch so these are all on the master.
Let me know how my first attempt is and thanks!