{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":707836982,"defaultBranch":"main","name":"executorch","ownerLogin":"dbort","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-10-20T19:17:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3828995?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1727388326.0","currentOid":""},"activityList":{"items":[{"before":"7a391d81c18d27bd7ce62ad8c84a822e9cb5db2c","after":"39c0e1c2eb42bb14756e74f168da303f81ab3055","ref":"refs/heads/export-D63294217","pushedAt":"2024-09-27T17:09:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Move etensor types to their new namespace (#5569)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/executorch/pull/5569\n\nMove these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`.\n\nMost users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal.\n\nAlso:\n- Hide bfloat16's `bits_from_f32`, which was only used by tests\n- Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`.\n- Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace\n\nReviewed By: swolchok\n\nDifferential Revision: D63294217","shortMessageHtmlLink":"Move etensor types to their new namespace (pytorch#5569)"}},{"before":"2387159c5de25fa13aaff60f8c2505f62c86d6e2","after":"7a391d81c18d27bd7ce62ad8c84a822e9cb5db2c","ref":"refs/heads/export-D63294217","pushedAt":"2024-09-27T16:11:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Move etensor types to their new namespace (#5569)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/executorch/pull/5569\n\nMove these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`.\n\nMost users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal.\n\nAlso:\n- Hide bfloat16's `bits_from_f32`, which was only used by tests\n- Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`.\n- Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace\n\nReviewed By: swolchok\n\nDifferential Revision: D63294217","shortMessageHtmlLink":"Move etensor types to their new namespace (pytorch#5569)"}},{"before":"5ee8ce4dfea94bc94f5e17a39b814984f0f307ad","after":"97e1fa5e44f077a7141954d63fcce3fe293660ae","ref":"refs/heads/export-D63476419","pushedAt":"2024-09-27T16:01:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Fix unqualified uses of executorch functions\n\nSummary:\nI'm not sure how this worked before, but these sites called functions under torch::executor without actually qualifying them. Qualify them explicitly, because the \"can call without qualification\" magic stops working when we move the etensor types in D63294217.\n\nIn a few places I used `namespace etrt = executorch::runtime;` instead of a using statement for a particular function, like `etrt::isIntegralType`. If I just say `using executorch::runtime::isIntegralType`, those files fail in aten mode because the unqualified call to `isIntegralType()` is deemed ambiguous in the presence of `c10::isIntegralType()` -- but afaict that `c10` version isn't `using`'d into the global namespace, so I don't know why it conflicts. It'd be good to figure that out at some point, but this works for now.\n\nI also updated custom_kernel_example to stop using the `torch::` namespace.\n\nReviewed By: swolchok\n\nDifferential Revision: D63476419","shortMessageHtmlLink":"Fix unqualified uses of executorch functions"}},{"before":"c67c41f957fc656ad4d1a8febea6743b3f4db616","after":"2387159c5de25fa13aaff60f8c2505f62c86d6e2","ref":"refs/heads/export-D63294217","pushedAt":"2024-09-27T16:01:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Move etensor types to their new namespace (#5569)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/executorch/pull/5569\n\nMove these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`.\n\nMost users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal.\n\nAlso:\n- Hide bfloat16's `bits_from_f32`, which was only used by tests\n- Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`.\n- Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace\n\nReviewed By: swolchok\n\nDifferential Revision: D63294217","shortMessageHtmlLink":"Move etensor types to their new namespace (pytorch#5569)"}},{"before":null,"after":"5ee8ce4dfea94bc94f5e17a39b814984f0f307ad","ref":"refs/heads/export-D63476419","pushedAt":"2024-09-26T22:05:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Fix unqualified uses of executorch functions\n\nSummary:\nI'm not sure how this worked before, but these sites called functions under torch::executor without actually qualifying them. Qualify them explicitly, because the \"can call without qualification\" magic stops working when we move the etensor types in D63294217.\n\nIn a few places I used `namespace etrt = executorch::runtime;` instead of a using statement for a particular function, like `etrt::isIntegralType`. If I just say `using executorch::runtime::isIntegralType`, those files fail in aten mode because the unqualified call to `isIntegralType()` is deemed ambiguous in the presence of `c10::isIntegralType()` -- but afaict that `c10` version isn't `using`'d into the global namespace, so I don't know why it conflicts. It'd be good to figure that out at some point, but this works for now.\n\nDifferential Revision: D63476419","shortMessageHtmlLink":"Fix unqualified uses of executorch functions"}},{"before":"99014350022715af1eaa334def0ba0233129587a","after":"c67c41f957fc656ad4d1a8febea6743b3f4db616","ref":"refs/heads/export-D63294217","pushedAt":"2024-09-26T22:04:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Move etensor types to their new namespace (#5569)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/executorch/pull/5569\n\nMove these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`.\n\nMost users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal.\n\nAlso:\n- Hide bfloat16's `bits_from_f32`, which was only used by tests\n- Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`.\n- Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace\n\nDifferential Revision: D63294217","shortMessageHtmlLink":"Move etensor types to their new namespace (pytorch#5569)"}},{"before":"3ce4d05625efd0b3cec70e2b250881068d38eae8","after":"99014350022715af1eaa334def0ba0233129587a","ref":"refs/heads/export-D63294217","pushedAt":"2024-09-24T01:05:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Move etensor types to their new namespace (#5569)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/executorch/pull/5569\n\nMove these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`.\n\nMost users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal.\n\nAlso:\n- Hide bfloat16's `bits_from_f32`, which was only used by tests\n- Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`.\n- Remove an unnecessary forward declaration from BlasKernel.h which conflicted with the new namespace\n\nDifferential Revision: D63294217","shortMessageHtmlLink":"Move etensor types to their new namespace (pytorch#5569)"}},{"before":null,"after":"3ce4d05625efd0b3cec70e2b250881068d38eae8","ref":"refs/heads/export-D63294217","pushedAt":"2024-09-23T23:34:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Move etensor types to their new namespace\n\nSummary:\nMove these types out of the old `torch::executor` namespace. Put them in their own namespace so that no-one will see them by default, unlike their old location in `torch::executor`.\n\nMost users should not use these directly, instead using the `executorch::aten` aliases. These ETensor types live under `executorch::runtime...` to make it a little more clear that they're semi-internal.\n\nAlso:\n- Hide bfloat16's `bits_from_f32`, which was only used by tests\n- Hide the `min` implementation used by string_view. Although it was in an anonymous namespace, it was in a header, so it was visible to all code in `torch::executor`.\n\nDifferential Revision: D63294217","shortMessageHtmlLink":"Move etensor types to their new namespace"}},{"before":"85190a19f963ab9cf73d976c6376bd798ef78953","after":null,"ref":"refs/heads/examples-mediatek","pushedAt":"2024-09-23T21:25:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"6469add458e50bc73c9383b56c39aa18a3d9eea4","after":null,"ref":"refs/heads/examples-cleanup","pushedAt":"2024-09-23T21:25:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"348d1d479c30023f86113eba23091415edfd17a2","after":null,"ref":"refs/heads/examples-devtools","pushedAt":"2024-09-23T21:25:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":null,"after":"bff5743ace7bf7b7f740625003ef9980d66b7226","ref":"refs/heads/docs-apple-cmake","pushedAt":"2024-09-20T22:58:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Add CMake instructions to apple-runtime.md\n\nTook me a bit to figure out how to make cmake work; I had it installed\nin homebrew but it wasn't working.\n\nAdd instructions for installing cmake globally in a way that Xcode can\nfind it.","shortMessageHtmlLink":"Add CMake instructions to apple-runtime.md"}},{"before":"896d4dcc688891249daf6d6529bb02763cf8cb4c","after":null,"ref":"refs/heads/phi3-fix","pushedAt":"2024-09-20T22:32:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"790df03e1917f2a865a24b7787bad33fa4d832dd","after":null,"ref":"refs/heads/examples-arm","pushedAt":"2024-09-20T22:30:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"5e855e156e3582ce0e3997b9bc5b288bb10762ad","after":null,"ref":"refs/heads/examples-ios","pushedAt":"2024-09-20T18:52:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":null,"after":"5e855e156e3582ce0e3997b9bc5b288bb10762ad","ref":"refs/heads/examples-ios","pushedAt":"2024-09-20T18:46:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Remove `torch::` namespace reference from LLaMMARunner.mm\n\nexamples/ code should use the new `executorch::` namespaces.\n\nTest Plan:\nBuilt the app using the instructions at https://github.com/pytorch/executorch/blob/main/examples/demo-apps/apple_ios/LLaMA/README.md","shortMessageHtmlLink":"Remove torch:: namespace reference from LLaMMARunner.mm"}},{"before":"3230f340467e4920c1e0cd7296c1e4babc514349","after":"896d4dcc688891249daf6d6529bb02763cf8cb4c","ref":"refs/heads/phi3-fix","pushedAt":"2024-09-20T17:58:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Fix phi-3-mini build\n\nFix the build errors I introduced in https://github.com/pytorch/executorch/pull/5318\n\nTest Plan:\nBuild the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md","shortMessageHtmlLink":"Fix phi-3-mini build"}},{"before":null,"after":"3230f340467e4920c1e0cd7296c1e4babc514349","ref":"refs/heads/phi3-fix","pushedAt":"2024-09-20T17:24:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Fix phi-3-mini build\n\nFix the build errors I introduced in https://github.com/pytorch/executorch/pull/5318\n\nTest Plan:\nBuild the model using the instructions at https://github.com/pytorch/executorch/blob/main/examples/models/phi-3-mini/README.md","shortMessageHtmlLink":"Fix phi-3-mini build"}},{"before":"fc00260bc2edeae95434504369e7a15601b8e0f7","after":"6469add458e50bc73c9383b56c39aa18a3d9eea4","ref":"refs/heads/examples-cleanup","pushedAt":"2024-09-20T17:23:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Remove stray uses of `torch::executor::` from examples/...","shortMessageHtmlLink":"Remove stray uses of torch::executor:: from examples/..."}},{"before":null,"after":"fc00260bc2edeae95434504369e7a15601b8e0f7","ref":"refs/heads/examples-cleanup","pushedAt":"2024-09-20T16:51:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Remove stray uses of `torch::executor::` from examples/...","shortMessageHtmlLink":"Remove stray uses of torch::executor:: from examples/..."}},{"before":null,"after":"790df03e1917f2a865a24b7787bad33fa4d832dd","ref":"refs/heads/examples-arm","pushedAt":"2024-09-20T02:14:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Remove `torch::` references from arm_executor_runner\n\nTest Plan:\nBuilt using the instructions at\nhttps://github.com/pytorch/executorch/blob/main/examples/arm/README.md","shortMessageHtmlLink":"Remove torch:: references from arm_executor_runner"}},{"before":null,"after":"348d1d479c30023f86113eba23091415edfd17a2","ref":"refs/heads/examples-devtools","pushedAt":"2024-09-19T20:08:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"Remove `torch::` references from devtools/example_runner\n\nUse the names in the new `executorch::` namespace.\n\nTest Plan:\n```\n./examples/devtools/build_example_runner.sh\n```","shortMessageHtmlLink":"Remove torch:: references from devtools/example_runner"}},{"before":"be09cb72bfe630fa5d9733af4671b7e7a3956d0e","after":"85190a19f963ab9cf73d976c6376bd798ef78953","ref":"refs/heads/examples-mediatek","pushedAt":"2024-09-19T18:53:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"[wip] Migrate examples/mediatek","shortMessageHtmlLink":"[wip] Migrate examples/mediatek"}},{"before":"44fe6f59b9ad4d774cdc01419185c04b0f462dd0","after":null,"ref":"refs/heads/examples-apple","pushedAt":"2024-09-19T17:00:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"c18cdd739670b2388de68219663b535d889eb807","after":null,"ref":"refs/heads/docs-fetch","pushedAt":"2024-09-19T16:58:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"7490be9223bc17eeed15b3c010f1224a1cd28722","after":null,"ref":"refs/heads/examples-qcom","pushedAt":"2024-09-18T22:42:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"}},{"before":"635bbb84d259212a7395d28466d87366fa5b2f7f","after":"be09cb72bfe630fa5d9733af4671b7e7a3956d0e","ref":"refs/heads/examples-mediatek","pushedAt":"2024-09-18T22:41:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"[wip] Migrate examples/mediatek","shortMessageHtmlLink":"[wip] Migrate examples/mediatek"}},{"before":"98b63210edb5914465ed85052da6cff12f49af1d","after":"7490be9223bc17eeed15b3c010f1224a1cd28722","ref":"refs/heads/examples-qcom","pushedAt":"2024-09-18T02:27:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"[wip] qcom namespace cleanup","shortMessageHtmlLink":"[wip] qcom namespace cleanup"}},{"before":null,"after":"635bbb84d259212a7395d28466d87366fa5b2f7f","ref":"refs/heads/examples-mediatek","pushedAt":"2024-09-18T02:10:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"[wip] Migrate examples/mediatek","shortMessageHtmlLink":"[wip] Migrate examples/mediatek"}},{"before":"444483efa11334b9f18233e7f65af5a8b8d22c49","after":"98b63210edb5914465ed85052da6cff12f49af1d","ref":"refs/heads/examples-qcom","pushedAt":"2024-09-18T01:31:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dbort","name":"Dave Bort","path":"/dbort","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3828995?s=80&v=4"},"commit":{"message":"[wip] qcom namespace cleanup","shortMessageHtmlLink":"[wip] qcom namespace cleanup"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QxNzowOTo1NC4wMDAwMDBazwAAAATC2XMf","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOFQwMTozMToyMC4wMDAwMDBazwAAAAS5IdoH"}},"title":"Activity ยท dbort/executorch"}