allow the configuration of executors memory during deploy #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
commented
Oct 14, 2024
| @@ -145,21 +147,37 @@ export async function deployAppCode( | |||
| } else { | |||
| logger.info("Time travel is disabled for this application"); | |||
| } | |||
| const ret = await registerApp(userDBName, host, enableTimeTravel, appName); | |||
| const ret = await registerApp(userDBName, host, enableTimeTravel, appName, executorsMemoryMib); | |||
There was a problem hiding this comment.
Set executors RAM when registering
maxdml
commented
Oct 14, 2024
Comment on lines
157
to
171
| logger.warn( | ||
| `Application ${chalk.bold(appName)} is deployed with database instance ${chalk.bold(appRegistered.PostgresInstanceName)}. Ignoring the provided database instance name ${chalk.bold( | ||
| userDBName | ||
| )}.` | ||
| ); | ||
| } | ||
|
|
||
| // Make sure the app database is the same. | ||
| if (appRegistered.ApplicationDatabaseName && (dbosConfig.database.app_db_name !== appRegistered.ApplicationDatabaseName)) { | ||
| logger.error(`Application ${chalk.bold(appName)} is deployed with app_db_name ${chalk.bold(appRegistered.ApplicationDatabaseName)}, but ${dbosConfigFilePath} specifies ${chalk.bold(dbosConfig.database.app_db_name)}. Please update the app_db_name field in ${dbosConfigFilePath} to match the database name.`); | ||
| if (appRegistered.ApplicationDatabaseName && dbosConfig.database.app_db_name !== appRegistered.ApplicationDatabaseName) { | ||
| logger.error( | ||
| `Application ${chalk.bold(appName)} is deployed with app_db_name ${chalk.bold(appRegistered.ApplicationDatabaseName)}, but ${dbosConfigFilePath} specifies ${chalk.bold( | ||
| dbosConfig.database.app_db_name | ||
| )}. Please update the app_db_name field in ${dbosConfigFilePath} to match the database name.` | ||
| ); |
maxdml
commented
Oct 14, 2024
Comment on lines
174
to
181
| // Check if the user wants to update the executors memory | ||
| if (executorsMemoryMib && appRegistered.ExecutorsMemoryMib !== executorsMemoryMib) { | ||
| const ret = await updateApp(host, appName, executorsMemoryMib, userCredentials); | ||
| if (ret !== 0) { | ||
| return 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
If the users provides a desired RAM amount, and this amount is different from what the application record has, then update the application record.
qianl15
force-pushed
the
configurable-ram
branch
from
0666106 to
ceccebe
Compare
kraftp
reviewed
Oct 14, 2024
| import axios, { AxiosError } from "axios"; | ||
| import { handleAPIErrors, getCloudCredentials, getLogger, isCloudAPIErrorResponse, retrieveApplicationName, DBOSCloudCredentials } from "../cloudutils.js"; | ||
|
|
||
| export async function updateApp(host: string, appName?: string, executorsMemoryMib?: number, userCredentials?: DBOSCloudCredentials): Promise<number> { |
There was a problem hiding this comment.
Let's make this a separate command, not part of deploy
…ements -- not as part of deploy
kraftp
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: