Secrets cli #657
Merged
Secrets cli #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
reviewed
Nov 19, 2024
packages/dbos-cloud/cli.ts
Outdated
Comment on lines
223
to
224
| .option("-s, --secretname <string>", "Specify the name of the secret to create") | ||
| .option("-v, --value <string>", "Specify the value of the secret to store with the name.") |
There was a problem hiding this comment.
Can we make these mandatory?
I think we can use this method
maxdml
reviewed
Nov 19, 2024
| } | ||
| logger.info(` ... app name is ${appName}.`); | ||
|
|
||
| logger.info(bearerToken); |
qianl15
reviewed
Nov 20, 2024
|
|
||
| const body = {'ApplicationName': appName , 'SecretName':secretName, 'ClearSecretValue': secretValue}; | ||
|
|
||
| console.log(body); |
qianl15
reviewed
Nov 20, 2024
| return 1; | ||
| } | ||
|
|
||
| logger.info(`Secret successfully created!`); |
There was a problem hiding this comment.
Suggested change
| logger.info(`Secret successfully created!`); | |
| logger.info(`Secret ${secretName} successfully created!`); |
qianl15
reviewed
Nov 20, 2024
| logger.error("Failed to get app name."); | ||
| return 1; | ||
| } | ||
| logger.info(` ... app name is ${appName}.`); |
There was a problem hiding this comment.
Suggested change
| logger.info(` ... app name is ${appName}.`); | |
| logger.debug(` ... app name is ${appName}.`); |
qianl15
reviewed
Nov 20, 2024
| } else { | ||
| const secrets = res.data as string[]; | ||
| secrets.forEach((secret) => { | ||
| logger.info(secret); |
There was a problem hiding this comment.
Probably also use console.log here as it's multiple lines.
kraftp
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) npx dbos-cloud app secrets create
(2) npx dbos-cloud app secrets list