Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html.table issue Children now mandatory to avoid type error #19

Open
jkone27 opened this issue Aug 23, 2022 · 0 comments
Open

Html.table issue Children now mandatory to avoid type error #19

jkone27 opened this issue Aug 23, 2022 · 0 comments
Labels
PR welcome Please provide a PR for this issue

Comments

@jkone27
Copy link

jkone27 commented Aug 23, 2022

i need now to specify TR as Children elements, else i get a type mismatch error, probably the default inferred signature has changed to the wrong one in latest versions

so conversion done with this doesnt work anymore out of the box too:
https://thisfunctionaltom.github.io/Html2Feliz/

error FS0193: Type constraint mismatch. The type 
    'ReactElement'    
is not compatible with type
    'IReactProperty'    
#r "nuget:Feliz.ViewEngine"
open Feliz.ViewEngine

let view =
    Html.table [
        Children [ // throws exception without specifying the Children constructor
            Html.tr [
                Html.th "Company"
                Html.th "Contact"
                Html.th "Country"
            ]
            Html.tr [
                Html.td "Alfreds Futterkiste"
                Html.td "Maria Anders"
                Html.td "Germany"
            ]
            Html.tr [
                Html.td "Centro comercial Moctezuma"
                Html.td "Francisco Chang"
                Html.td "Mexico"
            ] 
        ]
    ]
    |> Render.htmlDocument
@dbrattli dbrattli added the PR welcome Please provide a PR for this issue label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR welcome Please provide a PR for this issue
Projects
None yet
Development

No branches or pull requests

2 participants