Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AdapterRegistered event to dynamic log level #141

Merged
merged 9 commits into from
Apr 5, 2024
Merged

Change AdapterRegistered event to dynamic log level #141

merged 9 commits into from
Apr 5, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Mar 29, 2024 •
edited
Loading

resolves https://dbtlabs.atlassian.net/browse/MNTL-191

Problem

The AdapterRegistered event is currently INFO level but some would prefer it to be DEBUG level.

Solution

Let the log level of AdapterRegistered be dynamic but default it to INFO to preserve current behavior and prevent breaking changes.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

mikealfare
mikealfare previously approved these changes Mar 29, 2024
View reviewed changes
@emmyoop emmyoop requested a review from mikealfare March 29, 2024 14:34
mikealfare
mikealfare previously approved these changes Mar 31, 2024
View reviewed changes
mikealfare
mikealfare reviewed Apr 2, 2024
View reviewed changes
dbt/adapters/factory.py Outdated Show resolved Hide resolved
@emmyoop emmyoop force-pushed the er/mntl-191-AdapterRegistered branch from cbeb0cb to 905b096 Compare April 2, 2024 19:18
@emmyoop emmyoop requested a review from mikealfare April 2, 2024 20:35
colin-rogers-dbt
colin-rogers-dbt requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on internal conversation unrelated to the code

@emmyoop emmyoop merged commit 7392deb into main Apr 5, 2024
11 checks passed
@emmyoop emmyoop deleted the er/mntl-191-AdapterRegistered branch April 5, 2024 14:59
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Apr 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmyoop @mikealfare @colin-rogers-dbt