Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and configure pre-commit #174

Merged
merged 21 commits into from
Apr 19, 2024
Merged

Add and configure pre-commit #174

merged 21 commits into from
Apr 19, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 16, 2024

Problem / Solution

We need to setup pre-commit. This PR also addresses the resulting violations.

Acceptance Criteria

Tasks

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 16, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare marked this pull request as draft April 16, 2024 02:11
@mikealfare mikealfare linked an issue Apr 16, 2024 that may be closed by this pull request
3 tasks
@mikealfare mikealfare changed the title Add and configure pre-commit Add and configure pre-commit Apr 16, 2024
@mikealfare mikealfare marked this pull request as ready for review April 16, 2024 03:23
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lacking some contexts on key components here

@mikealfare mikealfare merged commit a9f1e14 into main Apr 19, 2024
13 checks passed
@mikealfare mikealfare deleted the config/add-precommit branch April 19, 2024 16:42
@dbeatty10
Copy link
Contributor

We should probably include install and usage instructions, so I opened this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Linting/pre-commit check on dbt-core as a dependency
4 participants