Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BaseMacroArgsQueryComments by removing ref to dbt_version in fixture #184

Merged
merged 3 commits into from
Apr 23, 2024
Merged

fix BaseMacroArgsQueryComments by removing ref to dbt_version in fixture #184

merged 3 commits into from
Apr 23, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review April 22, 2024 23:13
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt changed the title fix BaseMacroArgsQueryComments package version to get it from dbt-core fix BaseMacroArgsQueryComments by removing ref to dbt_version in fixture Apr 23, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit 596b44c into main Apr 23, 2024
13 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the correctlyGetAdapterVersion branch April 23, 2024 19:32
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Apr 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian3031 damian3031 damian3031 left review comments

@mikealfare mikealfare mikealfare approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @mikealfare @damian3031