Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config unit tests for CI #22

Merged
merged 13 commits into from
Jan 17, 2024
Merged

Config unit tests for CI #22

merged 13 commits into from
Jan 17, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jan 13, 2024

resolves #10

Setup unit tests to run automatically against main

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jan 13, 2024
@mikealfare mikealfare marked this pull request as ready for review January 16, 2024 18:59
@mikealfare

This comment was marked as resolved.

@mikealfare

This comment was marked as resolved.

@mikealfare mikealfare requested a review from a team January 16, 2024 22:29
emmyoop
emmyoop previously approved these changes Jan 17, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Just a question on why you save the results.

We should find out if we need both the matrix for python version in the workflow and the python version tests defined in pyroject.toml. Not a blocker to getting tests running on your PRs though.

.github/workflows/unit_tests.yml Show resolved Hide resolved
Co-authored-by: Emily Rockman <ebuschang@gmail.com>
@mikealfare
Copy link
Contributor Author

We should find out if we need both the matrix for python version in the workflow and the python version tests defined in pyroject.toml.

Agreed. My concern is that I don't know how to run integration tests in parallel using the hatch env matrix. They would run in parallel on the machine, but not as separate workflows in GHA. We're already running into memory issues for Redshift on Windows, so I want to split across machines. There might be a plugin for hatch that does this, I just haven't looked into it.

@mikealfare mikealfare merged commit 3929ed2 into main Jan 17, 2024
4 checks passed
@mikealfare mikealfare deleted the config/ci/unit-tests branch January 17, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI workflows
2 participants