-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config unit tests for CI #22
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Just a question on why you save the results.
We should find out if we need both the matrix for python version in the workflow and the python version tests defined in pyroject.toml. Not a blocker to getting tests running on your PRs though.
Co-authored-by: Emily Rockman <ebuschang@gmail.com>
Agreed. My concern is that I don't know how to run integration tests in parallel using the hatch env matrix. They would run in parallel on the machine, but not as separate workflows in GHA. We're already running into memory issues for Redshift on Windows, so I want to split across machines. There might be a plugin for hatch that does this, I just haven't looked into it. |
resolves #10
Setup unit tests to run automatically against
main
Checklist