Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_catalog_for_single_relation macro and capability #231

Merged
merged 22 commits into from
Jun 18, 2024
Merged

Add get_catalog_for_single_relation macro and capability #231

merged 22 commits into from
Jun 18, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented May 28, 2024 •
edited
Loading

Problem

We want to allow fetching object-level stats for materialized objects in the DWH as an alternative to hitting information_schema tables.

Solution

Create stubs for the new get_catalog_for_single_relation macro and GetCatalogForSingleRelation capability.

Accompanying Snowflake PR: dbt-labs/dbt-snowflake#1064

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label May 28, 2024
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

aranke
aranke commented May 28, 2024
View reviewed changes
dbt/adapters/base/impl.py Outdated Show resolved Hide resolved
aranke
aranke commented May 28, 2024
View reviewed changes
dbt/adapters/sql/impl.py Outdated Show resolved Hide resolved
@jtcohen6 jtcohen6 mentioned this pull request May 28, 2024
Merged
4 tasks
@aranke aranke mentioned this pull request May 29, 2024
Merged
5 tasks
@aranke aranke marked this pull request as ready for review May 29, 2024 14:13
@aranke aranke requested a review from a team as a code owner May 29, 2024 14:13
@aranke aranke changed the title Add get_relation_metadata capability Add get_relation_metadata macro and capability May 29, 2024
@aranke aranke marked this pull request as draft June 3, 2024 10:43
@aranke aranke mentioned this pull request Jun 3, 2024
Merged
5 tasks
@aranke aranke changed the title Add get_relation_metadata macro and capability Add get_metadata_for_single_relation macro and capability Jun 3, 2024
@aranke aranke changed the title Add get_metadata_for_single_relation macro and capability Add get_catalog_for_single_relation macro and capability Jun 3, 2024
@aranke aranke marked this pull request as ready for review June 11, 2024 16:38
mikealfare
mikealfare reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly where it needs to be. I left a few minor comments and addressed the question you had.

pyproject.toml Outdated Show resolved Hide resolved
dbt-tests-adapter/dbt/tests/adapter/basic/test_get_catalog_for_single_relation.py Outdated Show resolved Hide resolved
dbt-tests-adapter/dbt/tests/adapter/basic/test_get_catalog_for_single_relation.py Outdated Show resolved Hide resolved
dbt-tests-adapter/dbt/tests/adapter/basic/test_get_catalog_for_single_relation.py Outdated Show resolved Hide resolved
dbt-tests-adapter/dbt/tests/adapter/basic/test_get_catalog_for_single_relation.py Outdated Show resolved Hide resolved
dbt-tests-adapter/dbt/tests/adapter/basic/test_get_catalog_for_single_relation.py Outdated Show resolved Hide resolved
dbt-tests-adapter/dbt/tests/adapter/basic/test_get_catalog_for_single_relation.py Outdated Show resolved Hide resolved
@aranke aranke merged commit 6687ccc into main Jun 18, 2024
15 checks passed
@aranke aranke deleted the get_relation_metadata branch June 18, 2024 20:27
@tuliolima tuliolima mentioned this pull request Jun 18, 2024
Closed
2 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Sep 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aranke @mikealfare @colin-rogers-dbt