Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query Timer Resolution #246

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Fix Query Timer Resolution #246

merged 3 commits into from
Jun 21, 2024

Conversation

peterallenwebb
Copy link
Contributor

Problem

Previous revisions limited the precision of query time measurements to whole seconds, which is too coarse.

Solution

Record the measurements at full precision, and limit logged values to three decimal places (i.e. millisecond precision) for readability.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@peterallenwebb peterallenwebb requested a review from a team as a code owner June 21, 2024 19:07
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb merged commit e964302 into main Jun 21, 2024
15 checks passed
@peterallenwebb peterallenwebb deleted the paw/fix-timer-resolution branch June 21, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants