Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional should_release_connection parameter to connection_named method #247

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jun 24, 2024

Problem

There's no way to stop the connection_named context manager from releasing its connection at the end.

Solution

Add an optional should_release_connection parameter that allows holding on to the connection.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Jun 24, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke marked this pull request as ready for review June 24, 2024 15:19
@aranke aranke requested a review from a team as a code owner June 24, 2024 15:19
@aranke aranke changed the title Add optional release_connection parameter to connection_named method Add optional release_connection parameter to connection_named method Jun 24, 2024
@aranke aranke changed the title Add optional release_connection parameter to connection_named method Add optional should_release_connection parameter to connection_named method Jun 24, 2024
@aranke aranke merged commit 0739850 into main Jun 26, 2024
15 checks passed
@aranke aranke deleted the connection_named_release_connection branch June 26, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants