Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Retrieving and using table/column descriptions from BigQuery #1265

Closed
3 tasks done
K-Oxon opened this issue Jun 25, 2024 · 1 comment
Closed
3 tasks done
Labels
enhancement New feature or request triage

Comments

@K-Oxon
Copy link

K-Oxon commented Jun 25, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-bigquery functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I propose to add functionality to the dbt-bigquery adapter to retrieve and use table and column descriptions directly from BigQuery. This would streamline the process of incorporating existing BigQuery metadata into dbt projects.

Technical approach
One possible implementation would be to modify the _get_dbt_columns_from_bq_table function within the adapter. By extending this function to extract and store the description attribute from BigQuery's SchemaField objects, we could seamlessly integrate these descriptions into the BigQueryColumn representation used by dbt.

def _get_dbt_columns_from_bq_table(self, table) -> List[BigQueryColumn]:

Describe alternatives you've considered

Currently, to get table/column descriptions into dbt, you have to copy them manually or write custom scripts. This is time consuming and error prone.

Who will this benefit?

This feature would be invaluable for

Data engineers and analysts: They could quickly bootstrap DBT projects using existing BigQuery metadata, saving significant time and effort.
Teams with established BigQuery metadata: This would enable a smooth transition to dbt, leveraging their existing documentation and knowledge.
Users of dbt-codegen and dbt-osmosis: These tools could automatically incorporate descriptions into generated dbt models.

Are you interested in contributing this feature?

No response

Anything else?

No response

@K-Oxon K-Oxon added enhancement New feature or request triage labels Jun 25, 2024
@amychen1776
Copy link

This is a great idea. However, given our north star around adapters/dbt core being stateless, this is not a feature functionality we will support in dbt-bigquery but rather an interface like dbt Cloud that can better manage metadata.

@amychen1776 amychen1776 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants