From 832f1db76643b31ea251da756d951cb035102fe9 Mon Sep 17 00:00:00 2001 From: Jacob Beck Date: Thu, 18 Apr 2019 08:09:18 -0600 Subject: [PATCH] PR feedback: handle null columns --- .../global_project/macros/materializations/archive/archive.sql | 2 +- .../dbt/include/bigquery/macros/materializations/archive.sql | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/dbt/include/global_project/macros/materializations/archive/archive.sql b/core/dbt/include/global_project/macros/materializations/archive/archive.sql index 5b9b3d71342..6e3e96c5f59 100644 --- a/core/dbt/include/global_project/macros/materializations/archive/archive.sql +++ b/core/dbt/include/global_project/macros/materializations/archive/archive.sql @@ -7,7 +7,7 @@ {% endmacro %} {% macro default__archive_hash_arguments(args) %} - md5({% for arg in args %}{{ arg }}{% if not loop.last %} || '|' || {% endif %}{% endfor %}) + md5({% for arg in args %}coalesce(cast({{ arg }} as varchar ), '') {% if not loop.last %} || '|' || {% endif %}{% endfor %}) {% endmacro %} {% macro create_temporary_table(sql, relation) %} diff --git a/plugins/bigquery/dbt/include/bigquery/macros/materializations/archive.sql b/plugins/bigquery/dbt/include/bigquery/macros/materializations/archive.sql index 5874de3ea83..7a95f440f83 100644 --- a/plugins/bigquery/dbt/include/bigquery/macros/materializations/archive.sql +++ b/plugins/bigquery/dbt/include/bigquery/macros/materializations/archive.sql @@ -5,7 +5,7 @@ {% macro bigquery__archive_hash_arguments(args) %} - to_hex(md5(concat({% for arg in args %}cast({{ arg }} as string){% if not loop.last %}, '|',{% endif %}{% endfor %}))) + to_hex(md5(concat({% for arg in args %}coalesce(cast({{ arg }} as string), ''){% if not loop.last %}, '|',{% endif %}{% endfor %}))) {% endmacro %} {% macro bigquery__create_columns(relation, columns) %}