[Impl] Call adapter.pre_model_hook + adapter.post_model_hook within TestTask

[jtcohen6]

Housekeeping

• I am a maintainer of dbt-core

Short description

Before running models, dbt runs an adapter-specified "hook." Note that this is different from user-configured model hooks. In dbt-snowflake, this is the mechanism we use for calling use warehouse {snowflake_warehouse}, and it's what we should also use for custom secondary roles (and other things in the future).

Here's where that happens within RunTask:

dbt-core/core/dbt/task/run.py

Lines 285 to 291 in 09243d1

	hook_ctx = self.adapter.pre_model_hook(context_config)
	try:
	result = MacroGenerator(
	materialization_macro, context, stack=context["context_macro_stack"]
	)()
	finally:
	self.adapter.post_model_hook(context_config, hook_ctx)

We want the same thing to happen within TestTask, for both data + unit tests:

dbt-core/core/dbt/task/test.py

Lines 143 to 146 in 09243d1

	# generate materialization macro
	macro_func = MacroGenerator(materialization_macro, context)
	# execute materialization macro
	macro_func()

dbt-core/core/dbt/task/test.py

Lines 216 to 225 in 09243d1

	# generate materialization macro
	macro_func = MacroGenerator(materialization_macro, context)
	# execute materialization macro
	try:
	macro_func()
	except DbtBaseException as e:
	raise DbtRuntimeError(
	f"An error occurred during execution of unit test '{unit_test_def.name}'. "
	f"There may be an error in the unit test definition: check the data types.\n {e}"
	)

This way, unit + data tests can use custom Snowflake warehouses.

Acceptance criteria

adapter.pre_model_hook + adapter.post_model_hook are being called within TestTask for unit + data tests.

Suggested Tests

I don't think we're doing a great job of testing that pre_model_hook and post_model_hook are called today.

Ideas:

• Patch the adapter to define a pre_model_hook and post_model_hook that logs, and ensure it logs during test execution.
• After [Impl] Allow generic tests to accept arbitrary configs #10197 is complete: Add to the functional tests in dbt-snowflake here here. A test configured with a snowflake_warehouse that does not exist should fail. Today, it doesn't, because it doesn't actually use this config.

Impact to Other Teams

Impact: Adapters

Will backports be required?

no

Context

Original issue:

• [CT-1123] Adapter pre_model_hook + post_model_hook for tests and compilation, too dbt-adapters#212

However, compilation is out of scope. This issue is focused only on adding these hook calls to TestTask.

[adrian-pasek-prv]

@jtcohen6 @McKnight-42 I'm not sure it resolved the issue with tests using pre/post hooks. When I configure +snowflake_warehouse under tests, it does not seem to take affect. Tests are still being executed with default WH set in the environment. I'm using the latest version.

#dbt_project.yml

tests:
    my_project:
      +snowflake_warehouse: "MY_WH_XS"