Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support --empty flag for snapshots #10372

Closed
3 tasks done
Tracked by #10151
d-cole opened this issue Jun 27, 2024 · 2 comments · Fixed by #10962
Closed
3 tasks done
Tracked by #10151

[Feature] Support --empty flag for snapshots #10372

d-cole opened this issue Jun 27, 2024 · 2 comments · Fixed by #10962
Assignees
Labels
empty Issues related to the --empty CLI flag enhancement New feature or request paper_cut A small change that impacts lots of users in their day-to-day snapshots Issues related to dbt's snapshot functionality unit tests Issues related to built-in dbt unit testing functionality

Comments

@d-cole
Copy link

d-cole commented Jun 27, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Support the empty flag for snapshots. Currently, dbt snapshot --empty results in the error: "Error: No such option: --empty Did you mean --help?". This means unit tests for models downstream of snapshots cannot run with the usual workflow.

Describe alternatives you've considered

Running upstreams of snapshots with --empty then running the snapshots. This makes configuring unit tests in CI much more complex as you need the additional steps:

  • Identify snapshots upstream of modified models
  • Run upstreams of snapshots as empty
  • Run snapshots

Who will this benefit?

Users of unit tests and snapshots

Are you interested in contributing this feature?

No response

Anything else?

No response

@d-cole d-cole added enhancement New feature or request triage labels Jun 27, 2024
@dbeatty10 dbeatty10 added the unit tests Issues related to built-in dbt unit testing functionality label Jul 2, 2024
@gshank gshank added snapshots Issues related to dbt's snapshot functionality unit tests Issues related to built-in dbt unit testing functionality and removed unit tests Issues related to built-in dbt unit testing functionality labels Jul 3, 2024
@dbeatty10
Copy link
Contributor

Thanks for opening this @d-cole !

We've got something similar open for seeds as well: #8981

We've added your issue for snapshots to #10151.

@dbeatty10 dbeatty10 removed the triage label Jul 17, 2024
@d-cole
Copy link
Author

d-cole commented Jul 24, 2024

Great, thank you @dbeatty10!

@dbeatty10 dbeatty10 added the empty Issues related to the --empty CLI flag label Sep 24, 2024
@dbeatty10 dbeatty10 changed the title [Feature] Support --empty for snapshots [Feature] Support --empty flag for snapshots Sep 24, 2024
@graciegoheen graciegoheen added the paper_cut A small change that impacts lots of users in their day-to-day label Oct 24, 2024
@gshank gshank self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
empty Issues related to the --empty CLI flag enhancement New feature or request paper_cut A small change that impacts lots of users in their day-to-day snapshots Issues related to dbt's snapshot functionality unit tests Issues related to built-in dbt unit testing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants