Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type hints to core/dbt/contracts/sql.py #10614

Closed
1 task done
QMalcolm opened this issue Aug 27, 2024 · 2 comments · Fixed by #10615
Closed
1 task done

Add missing type hints to core/dbt/contracts/sql.py #10614

QMalcolm opened this issue Aug 27, 2024 · 2 comments · Fixed by #10615
Assignees

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

We're putting some effort into improving our typing. There are two type errors in core/dbt/contracts/sql.py, we should fix them.

core/dbt/contracts/sql.py:32: error: Function is missing a return type annotation  [no-untyped-def]
core/dbt/contracts/sql.py:32: note: Use "-> None" if function does not return a value
core/dbt/contracts/sql.py:43: error: Function is missing a return type annotation  [no-untyped-def]

Acceptance criteria

The type issues are fixed

Suggested Tests

N/A

Impact to Other Teams

None

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm self-assigned this Aug 27, 2024
@caineblood
Copy link

The above comment asking you to download a file is malware to steal your account; do not under any circumstances download or run it. The post needs to be removed. If you have attempted to run it please have your system cleaned and your account secured immediately.

@QMalcolm
Copy link
Contributor Author

The above comment asking you to download a file is malware to steal your account; do not under any circumstances download or run it. The post needs to be removed. If you have attempted to run it please have your system cleaned and your account secured immediately.

@caineblood thanks for pointing that out. Hopefully your message reached people before they clicked on it. Luckily, this should be a relatively low traffic issue, so I don't expect many saw it / interacted with it 🤞 I have deleted the offending comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants