Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test utility to patch microbatch end time #10713

Closed
1 task done
Tracked by #10624
MichelleArk opened this issue Sep 14, 2024 · 1 comment · Fixed by #10712
Closed
1 task done
Tracked by #10624

Add test utility to patch microbatch end time #10713

MichelleArk opened this issue Sep 14, 2024 · 1 comment · Fixed by #10712
Assignees

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of introducing microbatch models, it will be necessary for concrete adapters to test their implementations against a base test defined in dbt-test-adapters. This base test will need to patch the current time, and while using freezegun is an option, it may be too imprecise and brittle for certain concrete adapters if their connectors rely on the current time for other pieces of functionality (e.g. cert validity).

Acceptance criteria

Introduce a test utility to narrowly patch current time for computing the bounds of a microbatch model.

Suggested Tests

N/A

Impact to Other Teams

None

Will backports be required?

No

Context

No response

@MichelleArk MichelleArk added the user docs [docs.getdbt.com] Needs better documentation label Sep 14, 2024
@MichelleArk MichelleArk removed the user docs [docs.getdbt.com] Needs better documentation label Sep 14, 2024
@MichelleArk MichelleArk self-assigned this Sep 14, 2024
@MichelleArk
Copy link
Contributor Author

resolved by: #10712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant