Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for db_groups/autocreate on redshift #2285

Closed
beckjake opened this issue Apr 1, 2020 · 2 comments
Closed

Add an integration test for db_groups/autocreate on redshift #2285

beckjake opened this issue Apr 1, 2020 · 2 comments
Labels
enhancement New feature or request stale Issues that have gone stale

Comments

@beckjake
Copy link
Contributor

beckjake commented Apr 1, 2020

Describe the feature

I want to add some integration tests for #2262

It seemed unreasonable to make a third party contributor go through the hassle of writing tests against env variables that don't yet exist on circleci/azure/my local test.env file for an account that didn't at the time exist.

I believe the test should work like this, based on my (probably poor) understanding of redshift permissions/credentials:

  • add a new profile to the test suite that sets db_groups/autocreate=True
    • the db_groups value should contain a group that the given user isn't in.
  • add a new test that:
    • creates a table accessible to the given group, but not the user, using the default profile(?)
    • switches to the new profile
    • selects from the above table as a source

cc @kyleabeauchamp - does this seem reasonable? Is there a use-case in particular that you have that I should try to cover?

Describe alternatives you've considered

no tests?

Additional context

Redshift only

Who will this benefit?

Tests are for everyone.

@beckjake beckjake added enhancement New feature or request triage labels Apr 1, 2020
@kyleabeauchamp
Copy link
Contributor

I think this sounds reasonable to me. I think the low-hanging fruit are just making sure the arguments get piped into boto correctly. During my initial testing, it seems like boto is pretty strict on typing so that's a good crutch as well.

In terms of full integration testing, I'm afraid I'm not enough of a Redshift DBA to give advice on what coverage is desirable :(.

@drewbanin drewbanin removed the triage label Apr 2, 2020
@drewbanin drewbanin added this to the Octavius Catto milestone Apr 2, 2020
@drewbanin drewbanin modified the milestones: Octavius Catto, dbt-next Apr 29, 2020
@jtcohen6 jtcohen6 removed this from the Marian Anderson milestone Jul 6, 2020
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Nov 25, 2021
@github-actions github-actions bot closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

4 participants