Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support persist docs on Snowflake: Relations and columns #2334

Closed
drewbanin opened this issue Apr 16, 2020 · 1 comment
Closed

Support persist docs on Snowflake: Relations and columns #2334

drewbanin opened this issue Apr 16, 2020 · 1 comment
Labels
enhancement New feature or request snowflake

Comments

@drewbanin
Copy link
Contributor

Child issue of #1573

Notes:

  • We can render multiline comments using $$ string quoting

To do:

  • Support persisting docs for relations (tables and views)
  • Support persisting docs for columns in tables and views

If the project specifies a column that does not exist in the destination table, the comment on column statement may fail. This is the desired behavior.

Challenges:

  • Snowflake does not support adding comments to views.... leave out support for view comments for the time being, but consider something like strict field validation for schema.yml #1570 to allow us to generate DDL for the view with comments included at build-time.
@drewbanin
Copy link
Contributor Author

closed by #2321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request snowflake
Projects
None yet
Development

No branches or pull requests

1 participant