Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots run many introspection queries #2392

Closed
drewbanin opened this issue May 4, 2020 · 1 comment
Closed

Snapshots run many introspection queries #2392

drewbanin opened this issue May 4, 2020 · 1 comment
Labels
bug Something isn't working performance snapshots Issues related to dbt's snapshot functionality stale Issues that have gone stale

Comments

@drewbanin
Copy link
Contributor

Describe the bug

Snapshots run many introspective queries. These queries:

  • Find the columns in the destination table
  • Find the columns in the staging table
  • Add columns as needed
  • Expand column types

Some of these queries are required, but others are a little bit duplicative and a function of the implementations of the adapter methods that are called in the snapshot task.

Steps To Reproduce

Run dbt snapshot and inspect the logs

Expected behavior

Let's deeply investigate the queries initiated by a dbt snapshot command and understand which are necessary and which are a function of the abstractions in the existing adapter function implementations.

See the comment here #2390 (review)

The output of dbt --version:

= 0.17.0, but this hasn't changed in a while

@drewbanin drewbanin added bug Something isn't working snapshots Issues related to dbt's snapshot functionality performance labels May 4, 2020
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance snapshots Issues related to dbt's snapshot functionality stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

1 participant