Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config: in dbt_project.yml, in loco + #3663

Closed
jtcohen6 opened this issue Jul 30, 2021 · 2 comments
Closed

Support config: in dbt_project.yml, in loco + #3663

jtcohen6 opened this issue Jul 30, 2021 · 2 comments
Labels
enhancement New feature or request stale Issues that have gone stale

Comments

@jtcohen6
Copy link
Contributor

Users find the + prefix very confusing. Its significance is unclear, it looks more special than it is, and many configs work equally well with and without it:

# dbt_project.yml
models:
  +materialized: view    # works
  installed_package:
    materialized: table  # also works

I don't want to get rid of the + prefix, since it's prevalent in our docs and across. Everything above should keep working. Instead, I'd like to make this the documented standard:

# dbt_project.yml
models:
  config:
    materialized: view
  installed_package:
    config:
      materialized: table

That would establish real consistency between dbt_project.yml and the syntax proposed in #2401 / added in #3616:

# models/whatever.yml
models:
  - name: my_model
    config:
      materialized: view

Questions

  • Since config is a dictionary, do we need it to be +config?
  • What if someone has a subdirectory or project named config? I'm willing to say... pick a different name.
@jtcohen6 jtcohen6 added the enhancement New feature or request label Jul 30, 2021
@jtcohen6 jtcohen6 mentioned this issue Jul 30, 2021
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jun 7, 2022
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

1 participant