Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Deprecated unittest aliases were removed in Python 3.11 #4132

Closed
1 task done
tirkarthi opened this issue Oct 26, 2021 · 2 comments
Closed
1 task done

[Bug] Deprecated unittest aliases were removed in Python 3.11 #4132

tirkarthi opened this issue Oct 26, 2021 · 2 comments
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! python Pull requests that update Python code tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@tirkarthi
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

dbt/test/integration/027_cycle_test/test_cycles.py:        with self.assertRaisesRegexp(Exception, message):
dbt/test/integration/027_cycle_test/test_cycles.py:        with self.assertRaisesRegexp(Exception, message):

assertRaisesRegexp was removed in Python 3.11 in PR python/cpython#28268

Expected Behavior

assertRaisesRegex is the recommended equivalent.

Steps To Reproduce

Python 3.11 will throw an error for the tests

Relevant log output

No response

Environment

- OS:Ubuntu
- Python:3.11
- dbt:

What database are you using dbt with?

other (mention it in "Additional Context")

Additional Context

No response

@tirkarthi tirkarthi added bug Something isn't working triage labels Oct 26, 2021
@jtcohen6
Copy link
Contributor

Thanks a bunch for this, @tirkarthi!

I'm going to open this up as a good, straightforward first contribution for anyone who wants it. Sounds like it's a two-line change :)

@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! python Pull requests that update Python code tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed triage labels Oct 26, 2021
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 8, 2021

Resolved by #4136

@jtcohen6 jtcohen6 closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! python Pull requests that update Python code tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

2 participants