Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-211] [Bug] Fix typing issues discovered in pre-commit work #4704

Open
1 task done
Tracked by #8387
iknox-fa opened this issue Feb 9, 2022 · 2 comments
Open
1 task done
Tracked by #8387

[CT-211] [Bug] Fix typing issues discovered in pre-commit work #4704

iknox-fa opened this issue Feb 9, 2022 · 2 comments
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins support_rotation A good task to pick up during support rotation tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@iknox-fa
Copy link
Contributor

iknox-fa commented Feb 9, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

A series of type-hint related errors were uncovered when examining out mypy configuration as a part of the work to implement pre-commit.

Rather than attempt to fix all of those errors as part of the original ticket, this follow-on was created and all mypy errors were suppressed. Search the codebase for the JIRA ticket number CT-211 to find all the ignores

Expected Behavior

--

Steps To Reproduce

--

Relevant log output

--

Environment

- OS:
- Python:
- dbt:

What database are you using dbt with?

No response

Additional Context

--
@iknox-fa iknox-fa added bug Something isn't working triage labels Feb 9, 2022
@github-actions github-actions bot changed the title [Bug] Fix typing issues discovered in pre-commit work [CT-211] [Bug] Fix typing issues discovered in pre-commit work Feb 9, 2022
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed triage labels Feb 10, 2022
@jtcohen6
Copy link
Contributor

This sounds relevant to our work on #4089 / in #4439

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Aug 10, 2022
@leahwicz leahwicz removed the stale Issues that have gone stale label Aug 11, 2022
@jtcohen6 jtcohen6 removed the bug Something isn't working label Aug 18, 2022
@leahwicz leahwicz added the support_rotation A good task to pick up during support rotation label Jan 18, 2023
@iknox-fa iknox-fa self-assigned this Jan 18, 2023
@iknox-fa iknox-fa mentioned this issue Jan 24, 2023
Closed
6 tasks
@jtcohen6 jtcohen6 added the repo ci/cd Testing and continuous integration for dbt-core + adapter plugins label Jun 25, 2023
@emmyoop emmyoop mentioned this issue Aug 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins support_rotation A good task to pick up during support rotation tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mypy fixes dbt-labs/dbt-core
3 participants
@jtcohen6 @leahwicz @iknox-fa