Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1541] Regression in logic for "selection criterion ... does not match any nodes" #6297

Closed
jtcohen6 opened this issue Nov 21, 2022 · 0 comments · Fixed by #6298
Closed
Labels
bug Something isn't working logging

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 21, 2022

Petit regression in the main branch, introduced by #6064

Caught by Sung in #6271 (comment), and Mila in Slack

Before

if spec.expect_exists:
alert_non_existence(spec.raw, direct_nodes)

def alert_non_existence(raw_spec, nodes):
if len(nodes) == 0:
warn_or_error(f"The selection criterion '{str(raw_spec)}' does not match any nodes")

After

if spec.expect_exists:
warn_or_error(NoNodesForSelectionCriteria(spec_raw=str(spec.raw)))

(missing the check for len(direct_nodes) == 0!)

@jtcohen6 jtcohen6 added bug Something isn't working Team:Language logging labels Nov 21, 2022
@github-actions github-actions bot changed the title Regression in logic for "selection criterion ... does not match any nodes" [CT-1541] Regression in logic for "selection criterion ... does not match any nodes" Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant