Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1947] --models not working as expected in Click cli #6782

Closed
Tracked by #6631
iknox-fa opened this issue Jan 30, 2023 · 2 comments
Closed
Tracked by #6631

[CT-1947] --models not working as expected in Click cli #6782

iknox-fa opened this issue Jan 30, 2023 · 2 comments
Assignees

Comments

@iknox-fa
Copy link
Contributor

iknox-fa commented Jan 30, 2023

Per #6774
@ChenyuLInx I figured it out! The tests fail for me locally, and then pass when I switch -m to -s in the arguments to run_dbt (83850f5)! It seems like this might be a genuine bug where we're not passing through --models/-m appropriately. That's important for backward compatibility.

Desirable behavior:

  • For almost all commands, --models should be a pure alias for --select (and the two should be mutually exclusive)
  • EXCEPTION: dbt list historically accepted both --select and --models, with slightly different behavior, which we've preserved for back compat

This issue was surfaced when running dbt test

@github-actions github-actions bot changed the title --models [CT-1947] --models Jan 30, 2023
@iknox-fa iknox-fa changed the title [CT-1947] --models --models not working as expected in Click cli Jan 30, 2023
@iknox-fa iknox-fa changed the title --models not working as expected in Click cli [CT-1947] --models not working as expected in Click cli Jan 30, 2023
@iknox-fa
Copy link
Contributor Author

Per BLG 1/30/23:
Good ideas:

  • Create one aliased models/select param use it for all tasks except list.
  • Re-name select and models MiltOption params to list_select and list_models.
  • Add re-named params to list and make any adjustments needed in list task
  • Hide list_models from help text .

@aranke
Copy link
Member

aranke commented Jan 31, 2023

Resolved by #6787

@aranke aranke closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants