-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2035] [Spike] Parsing: model ‘version’ attribute #6866
Comments
We should leave space for adding other versioning schemes in the future (namely SemVer). For now, that can be as simple as creating lightweight abstractions over the logic to:
|
@MichelleArk assigning us for refinement :) |
Are we going to have multiple models with the same name separated only by the version? What would the unique id look like in this case? It's a departure from how we're handling unique id now. Would it be handled similar to how we handle disabled models? Do all versions of the same model get linked into the DAG? |
Conversation during Language team estimation yesterday:
|
Idea from @heysweet: Now that we're requiring users to tell us which model version is |
I like it! Less validation necessary and it's easier on the eyes in terms of sifting through versions to find the latest one. I've updated the description. |
I've proposed versions:
- v: 2
- v: 1
config:
alias: dim_customers
...
- v: 3 Relevant comment in discussion: |
closing in favor of implementation issue: #7263 |
Introduce an optional ‘versions’ attribute on model yaml entry.
versions
is a list of 'version' structures. Pseudocode:versions
will be specified within a single model yaml entry, but each version should maps to an individual node in the manifest with aunique_id
:model.<project_name>.<model_name>.v<version>
.Example:
Notes:
name
is defined in the yaml file, and is globally unique but shared amongversions
of that modelimplemented_by
property points to the name of a.sql
(or.py
) file that implements that model version. By convention, this file is<model_name>.v<version>.sql
, e.g.dim_customers.v2.sql
. However, users could setimplemented_by
to point to a different SQL file that doesn't meet the default naming convention. (These file names must be globally unique, even though they are not the actual modelname
.)The text was updated successfully, but these errors were encountered: