Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2399] Consolidate changelogs into single rc #7327

Closed
emmyoop opened this issue Apr 11, 2023 · 3 comments · Fixed by #7355
Closed

[CT-2399] Consolidate changelogs into single rc #7327

emmyoop opened this issue Apr 11, 2023 · 3 comments · Fixed by #7355
Assignees

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 11, 2023

We want to consolidate all beta changelogs into a single rc changelog in core and all adapters.

This is not currently automated so need we need to do this manually, locally.

Steps to follow:

  1. Create your branch off the 1.5.latest branch. This means we need to do this step after cutting the 1.5..latest branch with the cut-release-branch action

  2. Set the env var for the core team: TODO: check that everyone is included

export CHANGIE_CORE_TEAM="emmyoop gshank QMalcolm peterallenwebb stu-k ChenyuLInx aranke iknox-fa versusfacit  nssalian mcknight-42 colin-rogers-dbt michelleark jtcohen6 dbeatty10 Mathyoub mikealfare"
  1. Generate the consolidated changelog
changie batch 1.5.0 --include 1.5.0 --move-dir 1.5.0 --prerelease rc1
  1. Merge and open PR against 1.5.latest

  2. Run the release as normal. The release is smart enough to see that the changelog for 1.5.0rc1 already exists and should skip that step of the release.

@emmyoop emmyoop self-assigned this Apr 11, 2023
@github-actions github-actions bot changed the title Consolidate changelogs into single rc [CT-2399] Consolidate changelogs into single rc Apr 11, 2023
@mikealfare
Copy link
Contributor

I updated the comment above to include myself in CHANGIE_CORE_TEAM

@mikealfare
Copy link
Contributor

mikealfare commented Apr 13, 2023

We need to adjust the third step. Changie generates the new file, 1.5.0rc1.md, but then immediately deletes it because rc1 is pre-release (--remove-prereleases). So the command should be:

changie batch 1.5.0 --include 1.5.0 --move-dir 1.5.0 --prerelease rc1

And then we would just need to manually delete those change logs.

@aranke aranke mentioned this issue Apr 13, 2023
6 tasks
@mikealfare
Copy link
Contributor

@aranke Note that I corrected the command in the original post, but then re-posted the incorrect one in my comment. I just fixed it.

@aranke aranke closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants