-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2652] Remove "Replaceable" class usage as much as possible #7802
Comments
Need to check that this isn't used in adapters as well. Might be easier/better to move it to the dbtMixin class. |
Added this issue to the 'Stabilize External Interfaces' Epic under |
Updated this issue to be scoped to the usage of Replaceable in dbt-core, since it is now defined in dbt-common. Its full deletion can be done as a separate issue in dbt-common, once dbt-adapters has gone through the same exercise. |
An initial pass was taken here: #7844 but will likely need to start from scratch given the artifact + dbt-common refactors since it was initially spiked. |
We pull in a Replaceable class which contains a "replace" method in a lot of our classes. This method is designed to replace the current object with a newly constructed one based on kwargs, and is in general not a very good idea. If we want to replace a current object it would be better to be a lot more explicit and intentional about what's happening.
Remove the usage Replaceable class where it's found in dbt-core, look for breakage, and determine if we really need to do this or could just update the current object.
The text was updated successfully, but these errors were encountered: