-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2734] Add metricflow_time_spine to the semantic manifest. #7938
Comments
I understand the current plan here is:
Question: Should dbt automatically create this model in every project? Even projects that are not using the Semantic Layer (defining semantic models / metrics) at all? |
I love the idea of using similar logic for finding the latest versioned model. Thanks for surfacing that discussion!
I don't think we should create the time spine if the project doesn't have semantic models for two reasons:
Ideally we're smart enough to know if a project has semantic models, and only create the time spine table if they do. |
Link to DSI changes task: https://linear.app/dbt-labs/issue/SEM-342/project-key-in-semantic-manifest |
Also, here's the schema from DSI for the project config: https://github.com/dbt-labs/dbt-semantic-interfaces/pull/95/files#diff-5c4c38db4204c3cf53b401e057f98e3686d3aa2d13ff5c391bd5036097115f21R258 |
From the standup meeting what I gathered was that the first step was for users to create this model themselves, from documentation. Is that correct? Is there documentation of what that would look like? |
@gshank That is correct! Here is the documentation https://github.com/dbt-labs/docs.getdbt.com/pull/3392/files#diff-526134beefd89cf44f090a6108f73da6cc639c7e0e6a5d35fa639a55057f9c7c |
Do we want the whole model stored in the SemanticManifest? Where? It's neither a semantic_model nor a metric... Or do we just want the relation name in config? |
I have code in the attached pull request to check for the "metricflow_time_spine" model and put the information in the semantic manifest config. But that doesn't get the table created. Do we want to tell people to always run that model first? Add it as a "depends_on.nodes" to all of the semantic models? We need some way to get the table actually created... |
Is this your first time submitting a feature request?
Describe the feature
We need to create a time spine model in the users dbt project to support cumulative metrics (full context here: https://www.notion.so/dbtlabs/Time-spine-for-SL-Beta-7c10850fcaf44d47ba0cf23b0a03f4b4). This will be a model that is fully managed by dbt. The user shouldn't have to think about configuring this model or need to write a seperate semantic manifest config.
We should automatically add this model to the semantic manifest, even if there is no semantic model config, so metricflow can use it for constructing cumulative metrics.
Describe alternatives you've considered
The user would create a semantic manifest file manually. This feels like unnecessary friction for since this model is an internal MetricFlow model, and not something a user should have to think about configuring.
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: