Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for merge_exclude_columns #8268

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Aug 1, 2023

resolves #8267

Problem

The source code here doesn't include TestMergeExcludeColumns like dbt-snowflake does here or dbt-redshift does here.

This is because merge wasn't a supported incremental strategy for dbt-postgres until 1.6 and adding relevant functional tests was overlooked during implementation in #6951.

The other related test cases have a class that pytest will pick up:

Solution

Implement a test case that pytest will pick up (namely a class that begins with "Test").

Prerequisites

In order for this PR to work, it needs this:

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc)

@cla-bot cla-bot bot added the cla:yes label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (db69473) to head (fbd7476).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8268      +/-   ##
==========================================
+ Coverage   88.97%   89.00%   +0.03%     
==========================================
  Files         181      181              
  Lines       22956    22956              
==========================================
+ Hits        20424    20431       +7     
+ Misses       2532     2525       -7     
Flag Coverage Δ
integration 86.17% <ø> (+0.03%) ⬆️
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.17% <ø> (+0.03%) ⬆️

Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added stale Issues that have gone stale and removed stale Issues that have gone stale labels Jan 30, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review September 21, 2024 00:07
@dbeatty10 dbeatty10 requested a review from a team as a code owner September 21, 2024 00:07
@dbeatty10 dbeatty10 merged commit 09e973d into main Sep 24, 2024
63 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/test-merge-exclude-columns branch September 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2898] [Feature] Enable merge_exclude_columns test for dbt-postgres
2 participants