Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2978] Fix untyped functions in context/base.py (mypy warning) #8394

Closed
Tracked by #8387
emmyoop opened this issue Aug 14, 2023 · 0 comments · Fixed by #8525
Closed
Tracked by #8387

[CT-2978] Fix untyped functions in context/base.py (mypy warning) #8394

emmyoop opened this issue Aug 14, 2023 · 0 comments · Fixed by #8525
Assignees
@QMalcolm
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Aug 14, 2023 •
edited
Loading

Problem

When we hit a mypy error the console is flooded with mypy warnings as well. Clean up the warning to improve developer experience.

Reproduction

Simply force a mypy error (change types) and the warnings will be generated.

Relevant Output

core/dbt/context/base.py:188: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
@emmyoop emmyoop mentioned this issue Aug 14, 2023
Open
@github-actions github-actions bot changed the title Fix untyped functions in context/base.py (mypy warning) [CT-2978] Fix untyped functions in context/base.py (mypy warning) Aug 14, 2023
@emmyoop emmyoop added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Aug 14, 2023
@QMalcolm QMalcolm mentioned this issue Aug 30, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix untyped functions in core/dbt/context/base.py dbt-labs/dbt-core
2 participants
@emmyoop @QMalcolm