-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dc/8546 semantic models in graph selection #8589
Dc/8546 semantic models in graph selection #8589
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8589 +/- ##
==========================================
- Coverage 86.61% 86.59% -0.02%
==========================================
Files 176 176
Lines 25678 25731 +53
==========================================
+ Hits 22240 22283 +43
- Misses 3438 3448 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Found it: dbt-core/core/dbt/graph/cli.py Line 24 in b39eeb3
Should be: DEFAULT_INCLUDES: List[str] = ["fqn:*", "source:*", "exposure:*", "metric:*", "semantic_model:*"] Then semantic models will be included when It does feel like there's a real opportunity for refactoring here. It feels odd that sources/exposures/semantic_models/metrics are "pointer" node types, as opposed to the "logical" node types (models/seeds/snapshots/tests/analyses), and only those are included by the But I think that's all out of scope for something we want to backport to v1.6! |
Thanks for the solid start @dave-connors-3 !! @MichelleArk is going to take this one over the finish line, so we can get it merged & backported for the next v1.6.x patch |
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4133 |
(cherry picked from commit bb4214b)
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4134 |
* Dc/8546 semantic models in graph selection (#8589) (cherry picked from commit bb4214b) * Update test_list.py to remove config "access" and remove group comparison from SemanticModel since there is no group --------- Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com> Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
resolves #8546
SemanticModelSelectionMethod
to allow fordbt ls -s "semantic_model:*"
dbt ls --resource-type semantic_model
as of 9/7
SemanticModelSelectionMethod
worksdbt ls
does not include semantic modelsdbt ls --resource-type semantic_model
yields no nodesProblem
Checklist