Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3092] Support optional label property for semantic layer objects #8595

Closed
Tracked by #8125
QMalcolm opened this issue Sep 8, 2023 · 2 comments · Fixed by #8646
Closed
Tracked by #8125

[CT-3092] Support optional label property for semantic layer objects #8595

QMalcolm opened this issue Sep 8, 2023 · 2 comments · Fixed by #8646
Assignees
Labels
Impact: SL semantic Issues related to the semantic layer

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Sep 8, 2023

Context

We currently allow for specifying an optional label property on metric nodes. This wasn't defined in dbt-semantic-interfaces previously because it was not identified as need in MetricFlow. MetricFlow would like to begin using this property, and would like it to exist on more objects. Thus labels are being added to a number of DSI protocols as defined in dbt-labs/dbt-semantic-interfaces#143. To begin parsing and propagating this labels on Metric nodes, SemanticModel nodes, Dimensions, and Measures.

Acceptance Criteria

  • A label can be specified on Metric nodes, SemanticModel nodes, Dimensions, and Measures
  • labels on Metric nodes, SemanticModel nodes, Dimensions, and Measures are serialized into the semantic_manifest.json

Blocked By

dbt-labs/dbt-semantic-interfaces#143.

@github-actions github-actions bot changed the title Support optional label property for semantic layer objects [CT-3092] Support optional label property for semantic layer objects Sep 8, 2023
@QMalcolm QMalcolm added the semantic Issues related to the semantic layer label Sep 8, 2023
@QMalcolm
Copy link
Contributor Author

QMalcolm commented Sep 8, 2023

This "technically" isn't blocked. We could add the labels to the noted classes. However, we won't be able to serialize them to the semantic_manifest.json until the the DSI releases the changes.

@emmyoop
Copy link
Member

emmyoop commented Sep 13, 2023

@QMalcolm looking at the blocking issue, is it accurate that Entity should also support an optional label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: SL semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants