You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this will need updates in both the InputFixture and given schemas. Currently they are different objects/types but we should consider unifying them to both inheriting from a Fixture class in order to share logic/structure for configurable formats.
Question: should the default format be overridable? Perhaps at the project-level? It could be annoying to always have to specify format: csv in every given and expect configuration when the project has a general preference for csv over dict@graciegoheen. Perhaps a top-level fixtures config in dbt_project.yml?
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
[Implementation] Support a configurable format: csv attribute on a given input and expect fixtures in unit tests
[CT-3110] [Implementation] Support a configurable format: csv attribute on a given input and expect fixtures in unit tests
Sep 12, 2023
It could be annoying to always have to specify format: csv in every given and expect configuration when the project has a general preference for csv over dict @graciegoheen. Perhaps a top-level fixtures config in dbt_project.yml?
@MichelleArk Yep, I think you're instinct is correct here. We should allow folks to override the default for the format config at the project level (similar to how we allow setting the severityconfig for data tests). What if this just went under unit-tests: in the dbt_project.yml?
unit-tests:
+format: csv # all unit tests
We can also open a new issue for this enhancement if this feels out of scope for the current ticket or needs more product / dx refinement.
Acceptance Criteria:
format: csv
dict
csv
Technical Considerations:
InputFixture
andgiven
schemas. Currently they are different objects/types but we should consider unifying them to both inheriting from aFixture
class in order to share logic/structure for configurable formats.Question: should the default
format
be overridable? Perhaps at the project-level? It could be annoying to always have to specifyformat: csv
in everygiven
andexpect
configuration when the project has a general preference forcsv
overdict
@graciegoheen. Perhaps a top-levelfixtures
config in dbt_project.yml?The text was updated successfully, but these errors were encountered: