Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3235] [TECH-DEBT] Remove unused documentable class method #8871

Closed
1 task done
dbeatty10 opened this issue Oct 18, 2023 · 0 comments · Fixed by #9008
Closed
1 task done

[CT-3235] [TECH-DEBT] Remove unused documentable class method #8871

dbeatty10 opened this issue Oct 18, 2023 · 0 comments · Fixed by #9008
Labels
enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@dbeatty10
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

If documentable isn't used anywhere, can we 🪓 axe it?

Acceptance criteria

  1. We assess if we want to keep this class method or not
  2. If we choose to, then we actually remove it

Impact to Other Teams

Unknown impact, but assumed that there would be no impact because it is unused.

Will backports be required?

No backports required.

Context

It is more clear if unused code is no longer in the code base.
@dbeatty10 dbeatty10 added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Oct 18, 2023
@github-actions github-actions bot changed the title [<project>] Remove unused documentable class method [CT-3235] [<project>] Remove unused documentable class method Oct 18, 2023
@dbeatty10 dbeatty10 added triage enhancement New feature or request and removed triage labels Oct 31, 2023
@QMalcolm QMalcolm mentioned this issue Nov 6, 2023
Merged
5 tasks
@QMalcolm QMalcolm changed the title [CT-3235] [<project>] Remove unused documentable class method [CT-3235] [TECH-DEBT] Remove unused documentable class method Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove documentable as it isn't used anywhere dbt-labs/dbt-core
1 participant
@dbeatty10