Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3459] [Feature] Add cleanup methods to various base tests in core that are known to create leftover schemas from ci/cd in adapters #9219

Closed
3 tasks done
McKnight-42 opened this issue Dec 5, 2023 · 1 comment · Fixed by #9195
Assignees
Labels
Team:Adapters Issues designated for the adapter area of the code tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@McKnight-42
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Going to clear out our test account used for dbt-redshift see that several tests defined in dbt-core are leaving hanging artifacts at a rate suggesting their not properly being dropped see: dbt-labs/dbt-redshift#675

Describe alternatives you've considered

We can go look at the tests and evaluate what part of the default schema Is being changed and create cleanup methods to drop that changed schema. then install the connecting pr branch to this issue into local adapter runs and run tests locally to make sure the caught tests are not leaving any more schemas and try to catch follow-up ones that may not be nuisance artifacts

Who will this benefit?

our testing alerts can hopefully start to be more clean and pointing to real failures and stem flow of slowly filling up our ci/cd databases till no tests are allowed to pass

Are you interested in contributing this feature?

yes

Anything else?

No response

@McKnight-42 McKnight-42 added enhancement New feature or request Team:Adapters Issues designated for the adapter area of the code labels Dec 5, 2023
@McKnight-42 McKnight-42 self-assigned this Dec 5, 2023
@github-actions github-actions bot changed the title [Feature] Add cleanup methods to various base tests in core that are known to create leftover schemas from ci/cd in adapters [CT-3459] [Feature] Add cleanup methods to various base tests in core that are known to create leftover schemas from ci/cd in adapters Dec 5, 2023
@McKnight-42 McKnight-42 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed enhancement New feature or request labels Dec 5, 2023
@mikealfare
Copy link
Contributor

@McKnight-42 Should we verify this is working somehow (hence re-open until verified)? Or are you comfortable with this as-is given that it only impacts tests (hence move to Done status)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Adapters Issues designated for the adapter area of the code tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants