Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3560] Remove usage of flags and tracking in WritableManifest #9390

Closed
1 task done
Tracked by #9099
MichelleArk opened this issue Jan 16, 2024 · 0 comments · Fixed by #9628
Closed
1 task done
Tracked by #9099

[CT-3560] Remove usage of flags and tracking in WritableManifest #9390

MichelleArk opened this issue Jan 16, 2024 · 0 comments · Fixed by #9628
Assignees

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Jan 16, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

Remove usage of dbt.tracking and dbt.flags from dbt/artifacts/schemas/manifest.py. If they were to be left in, these would represent a dependency on dbt internals from an upstream component, and it could not be packaged separately.

Current usage: https://github.com/dbt-labs/dbt-core/pull/9377/files#diff-a0f1c7a8ab56c28a02547801a741a8139854ac72e0e2e8b556f9ebb7d5b9f7ffR15-R16

Acceptance criteria

dbt/artifacts does not contain imports or usage of dbt.tracking or dbt.flags.

Impact to Other Teams

N/A - should be a refactor.

Will backports be required?

nope

Context

@github-actions github-actions bot changed the title Remove usage of flags and tracking in WritableManifest [CT-3560] Remove usage of flags and tracking in WritableManifest Jan 16, 2024
@martynydbt martynydbt assigned emmyoop and unassigned gshank Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants