Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise deprecation warning if installed package overrides built-in materialization #9981

Closed
1 task done
MichelleArk opened this issue Apr 18, 2024 · 1 comment · Fixed by #9971
Closed
1 task done
Assignees
Labels
backport 1.6.latest backport 1.7.latest user docs [docs.getdbt.com] Needs better documentation

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Apr 18, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

We are deprecating the ability for installed packages to override built-in materializations without explicit opt-in from the user.

Users should still be able to wrap the built-in materialization in their root project to avoid this deprecation warning. e.g:

{% materialization view, default %}
 {{ return(my_cool_package.materialization_view_default()) }}
{% endmaterialization %}

Acceptance criteria

  • Overriding a built-in materialization from an installed package raises a deprecation warning
  • Using a custom materialization from an installed package does not raise a deprecation warning
  • Using a built-in materialization package override from the root project via a wrapping materialization is not deprecated, no warning

Suggested Tests

reads from acceptance criterea

Impact to Other Teams

N/A

Will backports be required?

yes -- to 1.7 and 1.6, 1.5 will be EOL'd in a few days.

Context

#9164

@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#5320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6.latest backport 1.7.latest user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants