Added svg format and option #365
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @abhijithp05 |
|
CLA has been signed |
|
Hope it gets reviews soon |
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
. |
| contextMenuClasses: ['graph-node-context-menu'] | ||
| menuItems: [ | ||
| { | ||
| id: "jump", |
There was a problem hiding this comment.
Why would you change all ' to "? Not only does this confuse the diff (there are much less real changes than it looks like), but you also make the code inconsistent (above your change, everything still uses single-quotes).
There was a problem hiding this comment.
Hi @mkielar, completely agree on the issue with the quotation marks. I am not a JS expert and familiar with the DBT repo; if this is the only issue I propose reverting to the original single-quote convention this snippet of code affected, since the original creator didn't follow up on this.
resolves #283
Description
Checklist
changie newto create a changelog entry