Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1807] Metrics should show yaml instead of compiled SQL in documentations #357

Closed
kalanyuz opened this issue Jan 12, 2023 · 4 comments
Closed
Labels

Comments

@kalanyuz
Copy link

Describe the feature

Since we write metric definitions in yaml to create semantic layer, the code section of metrics show the yaml definition and not compile SQL code.

Describe alternatives you've considered

Add another tab for YAML instead of replacing the code section entirely.

Are you interested in contributing this feature?

Yes. I would need a lead on where should I look to add this feature.

@kalanyuz kalanyuz added enhancement New feature or request triage labels Jan 12, 2023
@github-actions github-actions bot changed the title Metrics should show yaml instead of compiled SQL in documentations [CT-1807] Metrics should show yaml instead of compiled SQL in documentations Jan 12, 2023
@kalanyuz kalanyuz changed the title [CT-1807] Metrics should show yaml instead of compiled SQL in documentations [Feature] Metrics should show yaml instead of compiled SQL in documentations Jan 12, 2023
@kalanyuz kalanyuz changed the title [Feature] Metrics should show yaml instead of compiled SQL in documentations [CT-1807] Metrics should show yaml instead of compiled SQL in documentations Jan 12, 2023
@callum-mcdata
Copy link

Hi @kalanyuz! I think we're directionally aligned on the fact that we want to expose more metric information inside the documentation but diverge slightly on how we'd like to do so. Instead of showing the yaml in the code section, we'd rather introduce all of the elements as details.

Given the dynamic nature of metrics, we may also want to remove the code section, as the sql associated with each metric is entirely dependent on how it is queried.

@kalanyuz
Copy link
Author

@callum-mcdata I'm happy to help out with this if you could point me to where to look.

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants