From 154a89d5456370157084ccbd206ebed0cb96348b Mon Sep 17 00:00:00 2001 From: Mike Alfare Date: Sun, 21 Apr 2024 21:44:11 -0400 Subject: [PATCH] rename scheduled workflows and variables --- .github/workflows/build-artifacts.yml | 61 ------------------- .github/workflows/daily-checks.yml | 10 +-- ...st-releases.yml => daily-dev-releases.yml} | 8 +-- .../dev-branch-integration-tests.yml | 6 +- .github/workflows/pull-request-checks.yml | 10 +-- .github/workflows/weekly-maintenance.yml | 2 +- 6 files changed, 18 insertions(+), 79 deletions(-) delete mode 100644 .github/workflows/build-artifacts.yml rename .github/workflows/{scheduled-test-releases.yml => daily-dev-releases.yml} (89%) diff --git a/.github/workflows/build-artifacts.yml b/.github/workflows/build-artifacts.yml deleted file mode 100644 index 2907f7f1e..000000000 --- a/.github/workflows/build-artifacts.yml +++ /dev/null @@ -1,61 +0,0 @@ -# **what?** -# Verifies python build on all code commited to the repository. This workflow -# should not require any secrets since it runs for PRs from forked repos. By -# default, secrets are not passed to workflows running from a forked repos. - -# **why?** -# Ensure code for dbt meets a certain quality standard. - -# **when?** -# This will run for all PRs, when code is pushed to main, and when manually triggered. -name: "Build release" - -on: - workflow_call: - inputs: - branch: - description: "The branch/tag to run integration tests on" - type: string - default: "main" - archive-name: - description: "The name to use for the upload archive, leave blank for no upload" - type: string - default: "" - workflow_dispatch: - inputs: - branch: - description: "The branch/tag to run integration tests on" - type: string - default: "main" - archive-name: - description: "The name to use for the upload archive, leave blank for no upload" - type: string - default: "" - -permissions: read-all - -concurrency: - group: "${{ github.workflow }}-${{ github.event_name }}-${{ inputs.archive-name }}" - cancel-in-progress: true - -jobs: - build: - name: "Build a release" - runs-on: ubuntu-latest - permissions: - id-token: write # IMPORTANT: this permission is mandatory for trusted publishing - steps: - - name: "Check out ${{ github.repository }}@${{ inputs.branch }}" - uses: actions/checkout@v4 - with: - ref: ${{ inputs.branch }} - - - name: "Setup environment" - uses: dbt-labs/dbt-adapters/.github/actions/setup-environment@update-workflows - with: - python-version: ${{ vars.DBT_TEST_PYTHON_VERSION }} - - - name: "Build ${{ github.event.repository.name }}" - uses: dbt-labs/dbt-adapters/.github/actions/build-artifacts@update-workflows - with: - archive-name: ${{ inputs.archive-name }} diff --git a/.github/workflows/daily-checks.yml b/.github/workflows/daily-checks.yml index 3143d2590..0ee4b5c99 100644 --- a/.github/workflows/daily-checks.yml +++ b/.github/workflows/daily-checks.yml @@ -9,7 +9,7 @@ # introduce breaking changes (could also impact Cloud). # **when?** -# - scheduled with the repository variable DBT_SCHEDULED_TESTS_SCHEDULE +# - daily based on DBT_DAILY_CHECKS_SCHEDULE # - manually name: "Daily checks" @@ -26,7 +26,7 @@ jobs: uses: ./.github/workflows/code-quality.yml strategy: matrix: - branch: ${{ fromJSON(vars.DBT_SCHEDULED_TESTS_BRANCHES) }} + branch: ${{ fromJSON(vars.DBT_DAILY_CHECKS_BRANCHES) }} with: branch: ${{ matrix.branch }} @@ -35,7 +35,7 @@ jobs: uses: ./.github/workflows/unit-tests.yml strategy: matrix: - branch: ${{ fromJSON(vars.DBT_SCHEDULED_TESTS_BRANCHES) }} + branch: ${{ fromJSON(vars.DBT_DAILY_CHECKS_BRANCHES) }} with: branch: ${{ matrix.branch }} @@ -44,7 +44,7 @@ jobs: uses: ./.github/workflows/integration-tests.yml strategy: matrix: - branch: ${{ fromJSON(vars.DBT_SCHEDULED_TESTS_BRANCHES) }} + branch: ${{ fromJSON(vars.DBT_DAILY_CHECKS_BRANCHES) }} with: branch: ${{ matrix.branch }} @@ -53,7 +53,7 @@ jobs: uses: dbt-labs/actions/.github/workflows/build-artifacts.yml@add-hatch-actions strategy: matrix: - branch: ${{ fromJSON(vars.DBT_SCHEDULED_TESTS_BRANCHES) }} + branch: ${{ fromJSON(vars.DBT_DAILY_CHECKS_BRANCHES) }} with: branch: ${{ matrix.branch }} diff --git a/.github/workflows/scheduled-test-releases.yml b/.github/workflows/daily-dev-releases.yml similarity index 89% rename from .github/workflows/scheduled-test-releases.yml rename to .github/workflows/daily-dev-releases.yml index 296e2b193..e7c1bddda 100644 --- a/.github/workflows/scheduled-test-releases.yml +++ b/.github/workflows/daily-dev-releases.yml @@ -9,17 +9,17 @@ # Ensure an automated and tested release process for nightly builds # # **when?** -# - scheduled with the repository variable DBT_SCHEDULED_TEST_RELEASES_SCHEDULE +# - daily based on DBT_DAILY_DEV_RELEASE_SCHEDULE # - manually -name: "Scheduled test releases" +name: "Daily test releases" on: schedule: - - cron: ${{ vars.DBT_SCHEDULED_TEST_RELEASES_SCHEDULE }} + - cron: ${{ vars.DBT_DAILY_DEV_RELEASE_SCHEDULE }} workflow_dispatch: permissions: - contents: write # this is the permission that allows creating a new release + contents: write # allows creating a new release defaults: run: diff --git a/.github/workflows/dev-branch-integration-tests.yml b/.github/workflows/dev-branch-integration-tests.yml index 5e413b23c..62a1da210 100644 --- a/.github/workflows/dev-branch-integration-tests.yml +++ b/.github/workflows/dev-branch-integration-tests.yml @@ -56,12 +56,12 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - python-version: ${{ fromJSON(vars.DBT_TEST_PYTHON_ALL_VERSIONS) }} + python-version: ${{ fromJSON(vars.DBT_PYTHON_VERSIONS) }} include: - os: macos-latest - python-version: ${{ vars.DBT_TEST_PYTHON_VERSION }} + python-version: ${{ vars.DBT_PYTHON_VERSION }} - os: windows-latest - python-version: ${{ vars.DBT_TEST_PYTHON_VERSION }} + python-version: ${{ vars.DBT_PYTHON_VERSION }} env: REDSHIFT_TEST_HOST: ${{ secrets.REDSHIFT_TEST_HOST }} REDSHIFT_TEST_PORT: ${{ vars.REDSHIFT_TEST_PORT }} diff --git a/.github/workflows/pull-request-checks.yml b/.github/workflows/pull-request-checks.yml index a5b3358f1..8c1637324 100644 --- a/.github/workflows/pull-request-checks.yml +++ b/.github/workflows/pull-request-checks.yml @@ -19,7 +19,7 @@ jobs: with: ref: ${{ github.event.pull_request.head.ref }} check-command: "hatch run code-quality" - python-version: ${{ vars.DBT_TEST_PYTHON_VERSION }} + python-version: ${{ vars.DBT_PYTHON_VERSION }} unit-tests: name: "Run unit tests" @@ -27,7 +27,7 @@ jobs: with: ref: ${{ github.event.pull_request.head.ref }} test-command: "hatch run unit-tests:all" - python-versions: ${{ vars.DBT_TEST_PYTHON_ALL_VERSIONS }} + python-versions: ${{ vars.DBT_PYTHON_VERSIONS }} integration-tests: name: "Run unit tests" @@ -35,9 +35,9 @@ jobs: with: ref: ${{ github.event.pull_request.head.ref }} test-command: "hatch run integration-tests:all" - python-versions-ubuntu: ${{ vars.DBT_TEST_PYTHON_ALL_VERSIONS }} - python-versions-macos: ${{ vars.DBT_TEST_PYTHON_VERSION }} - python-versions-windows: ${{ vars.DBT_TEST_PYTHON_VERSION }} + python-versions-ubuntu: ${{ vars.DBT_PYTHON_VERSIONS }} + python-versions-macos: ${{ vars.DBT_PYTHON_VERSION }} + python-versions-windows: ${{ vars.DBT_PYTHON_VERSION }} verify-build-artifacts: name: "Verify build artifacts" diff --git a/.github/workflows/weekly-maintenance.yml b/.github/workflows/weekly-maintenance.yml index c255a0536..7503fd52d 100644 --- a/.github/workflows/weekly-maintenance.yml +++ b/.github/workflows/weekly-maintenance.yml @@ -9,7 +9,7 @@ # - allow automated processes to leave artifacts for debugging and troubleshooting # # **when?** -# - weekly base on DBT_WEEKLY_MAINTENANCE_SCHEDULE +# - weekly based on DBT_WEEKLY_MAINTENANCE_SCHEDULE # - manually # # Runs on Saturday to avoid running at the same time as production release and breaking the release.