-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build docker for postgres integration test #344
Comments
I'm also have the same issue. Did you ever figure out the fix @bastienboutonnet ? |
Nope. So I just leveraged the CI that gets spun up on PR |
Hey both - I also had trouble with the integration tests recently (and fell back to making the CI job do it). Planning to sit down with @VersusFacit in the new year and get this sorted out 🛠️ |
That's what I was planning on doing as well for this PR but the CI job never ran when I pushed the PR. Any idea why that would be? |
No, but I also got caught up by that, and then when we asked the dev team for help it worked without a hitch! |
@bastienboutonnet definitely not you being dumb -- the documentation was not accurate. I tried re-factoring the Makefile and the instructions to try to address the issues you raised within #591 You can try it out with the following steps:
I'm trying to balance the number of steps to execute as a user versus how much gets re-run every time within the Any suggestions are welcome -- just add your feedback within #591 |
Describe the bug
When trying to test a recent change I proposed on the
haversine_disance
macro, I wanted to follow the instructions laid out in the README.md to set up a postgres dockerHowever when running
make test target=postgres
I bumped into the following error
Steps to reproduce
Described above.
Expected results
I would expect the docker to build correctly as this section suggests?
Maybe, I'm being dumb and misreading the documentation, it wouldn't be the first time, if not and the documentation isn't accurate anymore or something else is happening I'd be happy to help fixing if there is anything I can do.
The text was updated successfully, but these errors were encountered: